[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

Brian Sumner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 14 07:35:43 PDT 2019


b-sumner added a comment.

In D62739#1543438 <https://reviews.llvm.org/D62739#1543438>, @arsenm wrote:

> In D62739#1536428 <https://reviews.llvm.org/D62739#1536428>, @b-sumner wrote:
>
> > We need to communicate with anyone generating IR to ensure this is being generated before we change the default.  clang is only one of those generators.  This change will also need to be documented in the usage document.
>
>
> The planned change is to make the backend more conservative, so it shouldn't break other frontends


It may not break other frontends, but could cause substantial performance regressions.  At a minimum the summary should clearly mention this possibility.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62739/new/

https://reviews.llvm.org/D62739





More information about the cfe-commits mailing list