[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size
Matt Arsenault via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jun 14 05:44:01 PDT 2019
arsenm added a comment.
In D62739#1536390 <https://reviews.llvm.org/D62739#1536390>, @yaxunl wrote:
> My concern is that this essentially forcing user to add amdgpu_flat_work_group_size attribute to all kernels that are executed outside of (128,256). Potentially this can cause lots of regressions for existing OpenCL apps. I am not sure if it is feasible to force all OpenCL apps to make this change. Should we do some tests before making this change?
This is already the case. This is just moving it to the frontend. There's no user observable change from this patch
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62739/new/
https://reviews.llvm.org/D62739
More information about the cfe-commits
mailing list