[PATCH] D58880: [clangd] Type hierarchy subtypes

[Nathan Ridge via Phabricator via cfe-commits]

nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1061
+  End.character = CD.End.column();
+  // TODO: How to get entire range like in declToTypeHierarchyItem()?
+  THI.range = {Start, End};
----------------
kadircet wrote:
> a few different approaches that comes to my mind:
> - store the full range in index.
> - check AST cache to see if we have AST for `CD.FileURI`, and use that decl.
> - build AST for `CD.FileURI`
> - heuristically parse `CD.FileURI`
> 
> 
> Could you create a bug report in https://github.com/clangd/clangd/issues ?
Filed https://github.com/clangd/clangd/issues/59.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58880/new/

https://reviews.llvm.org/D58880