[PATCH] D62944: [Driver] Fix wchar_t and wint_t definitions on Solaris

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 13 11:01:43 PDT 2019


efriedma added a comment.

For format-strings.c, I'm not really happy suggesting `#if defined(__sun) && !defined(__LP64__)`, but I don't think the alternative is better.  We could restrict the test so it doesn't run using a Solaris target triple, but we actually want coverage here: the difference in wint_t affects the semantics of "%lc", so we want some coverage of that path.

The other changes look okay.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62944/new/

https://reviews.llvm.org/D62944





More information about the cfe-commits mailing list