[PATCH] D63260: [Attr] Support _attribute__ ((fallthrough))

Dávid Bolvanský via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 13 10:58:58 PDT 2019


xbolva00 marked 2 inline comments as done.
xbolva00 added inline comments.


================
Comment at: test/Sema/address_spaces.c:12
 {
-  _AS2 *x;// expected-warning {{type specifier missing, defaults to 'int'}}
+  _AS2 *x;// expected-error {{use of undeclared identifier 'x'}}
   _AS1 float * _AS2 *B;
----------------
I think this is an acceptable change..


================
Comment at: test/SemaCXX/warn-unused-label-error.cpp:23
       #pragma weak unused_local_static
-      __attribute__((unused))  // expected-warning {{declaration does not declare anything}}
+      __attribute__((unused))  // expected-error {{'unused' attribute cannot be applied to a statement}}
       ;
----------------
I think this is an improvement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63260/new/

https://reviews.llvm.org/D63260





More information about the cfe-commits mailing list