[PATCH] D63161: Devirtualize destructor of final class.
Hiroshi Yamauchi via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jun 12 15:05:42 PDT 2019
yamauchi updated this revision to Diff 204365.
yamauchi added a comment.
Using getDevirtualizedMethod.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63161/new/
https://reviews.llvm.org/D63161
Files:
lib/CodeGen/CGExprCXX.cpp
test/CodeGenCXX/devirtualize-dtor-final.cpp
Index: test/CodeGenCXX/devirtualize-dtor-final.cpp
===================================================================
--- /dev/null
+++ test/CodeGenCXX/devirtualize-dtor-final.cpp
@@ -0,0 +1,17 @@
+// RUN: %clang_cc1 -triple i386-unknown-unknown -std=c++11 %s -emit-llvm -o - | FileCheck %s
+
+namespace Test1 {
+ struct A { virtual ~A() {} };
+ struct B final : public A {};
+ struct C : public A { virtual ~C() final {} };
+ // CHECK-LABEL: define void @_ZN5Test13fooEPNS_1BE
+ void foo(B *b) {
+ // CHECK: call void @_ZN5Test11BD1Ev
+ delete b;
+ }
+ // CHECK-LABEL: define void @_ZN5Test14foo2EPNS_1CE
+ void foo2(C *c) {
+ // CHECK: call void @_ZN5Test11CD1Ev
+ delete c;
+ }
+}
Index: lib/CodeGen/CGExprCXX.cpp
===================================================================
--- lib/CodeGen/CGExprCXX.cpp
+++ lib/CodeGen/CGExprCXX.cpp
@@ -1865,9 +1865,15 @@
Dtor = RD->getDestructor();
if (Dtor->isVirtual()) {
- CGF.CGM.getCXXABI().emitVirtualObjectDelete(CGF, DE, Ptr, ElementType,
- Dtor);
- return;
+ if (auto *DevirtualizedDtor = dyn_cast_or_null<const CXXDestructorDecl>(
+ Dtor->getDevirtualizedMethod(DE->getArgument(),
+ CGF.CGM.getLangOpts().AppleKext)))
+ Dtor = DevirtualizedDtor;
+ else {
+ CGF.CGM.getCXXABI().emitVirtualObjectDelete(CGF, DE, Ptr, ElementType,
+ Dtor);
+ return;
+ }
}
}
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63161.204365.patch
Type: text/x-patch
Size: 1592 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190612/9eaa19fa/attachment.bin>
More information about the cfe-commits
mailing list