[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

mark sure you mark off the comments as you consider them done.



================
Comment at: lib/Format/FormatToken.h:519
 
+/// Returns whether the token is a Bit field, and checks whether
+/// the Style is C / C++.
----------------
this looks like it needs a clang-format as its not aligned with function that follows


================
Comment at: lib/Format/FormatToken.h:527
+    return true;
+  return false;
+}
----------------

couldn't you write this as just and lose the ``if``


```
return (T->Tok.is(tok::comma) && Tok.is(tok::identifier) && T->Next->Tok.is(tok::colon));
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63062/new/

https://reviews.llvm.org/D63062