r363041 - [Frontend] Avoid creating auxilary files during a unit test. NFC

Ilya Biryukov via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 11 02:52:30 PDT 2019


Author: ibiryukov
Date: Tue Jun 11 02:52:30 2019
New Revision: 363041

URL: http://llvm.org/viewvc/llvm-project?rev=363041&view=rev
Log:
[Frontend] Avoid creating auxilary files during a unit test. NFC

A test added in r363009 logs diagnostics into a file inside current
working directory. This breaks when the directory is not writable.

This looks like a debugging output in the first place, the test passes
without it anyway.

Modified:
    cfe/trunk/unittests/Frontend/CompilerInstanceTest.cpp

Modified: cfe/trunk/unittests/Frontend/CompilerInstanceTest.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Frontend/CompilerInstanceTest.cpp?rev=363041&r1=363040&r2=363041&view=diff
==============================================================================
--- cfe/trunk/unittests/Frontend/CompilerInstanceTest.cpp (original)
+++ cfe/trunk/unittests/Frontend/CompilerInstanceTest.cpp Tue Jun 11 02:52:30 2019
@@ -73,7 +73,6 @@ TEST(CompilerInstance, DefaultVFSOverlay
 
 TEST(CompilerInstance, AllowDiagnosticLogWithUnownedDiagnosticConsumer) {
   auto DiagOpts = new DiagnosticOptions();
-  DiagOpts->DiagnosticLogFile = "log.diags";
 
   // Create the diagnostic engine with unowned consumer.
   std::string DiagnosticOutput;




More information about the cfe-commits mailing list