[PATCH] D63126: [clangd] Implement "prepareRename"

[Haojian Wu via Phabricator via cfe-commits]

hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov.
Herald added a project: clang.

"prepareRename" request is added in LSP v3.12.0.

No test yet, but want some early feedback.

Unfortunately, due to the bug in VSCode LSP[1], the rename dialog still
shows up when we return null in prepareRename. The fix is not released
in the latest version.

[1]: https://github.com/microsoft/vscode-languageserver-node/issues/447


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63126

Files:
  clang-tools-extra/clangd/ClangdLSPServer.cpp
  clang-tools-extra/clangd/ClangdLSPServer.h
  clang-tools-extra/clangd/ClangdServer.cpp
  clang-tools-extra/clangd/ClangdServer.h
  clang-tools-extra/clangd/Protocol.cpp
  clang-tools-extra/clangd/Protocol.h
  clang-tools-extra/clangd/refactor/Rename.cpp
  clang-tools-extra/clangd/refactor/Rename.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63126.203991.patch
Type: text/x-patch
Size: 8293 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190611/95c330fa/attachment.bin>