[PATCH] D59744: Fix i386 ABI "__m64" type bug

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 10 16:15:59 PDT 2019


rjmccall added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:1005
   bool IsMCUABI;
+  bool IsLinuxABI;
   unsigned DefaultNumRegisterParameters;
----------------
mgorny wrote:
> Maybe replace the two booleans with something alike `IsPassInMMXRegABI`? And while at it, include NetBSD there, please.
`CGT` is a member variable, so you can just query the target fresh in your `isPassInMMXRegABI` method.  The check upfront for a 64-bit vector type should keep this well out of the fast path.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59744/new/

https://reviews.llvm.org/D59744





More information about the cfe-commits mailing list