[PATCH] D63088: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code
Matthias Gehre via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 10 12:17:45 PDT 2019
mgehre updated this revision to Diff 203873.
mgehre added a comment.
Fix rewrapped comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63088/new/
https://reviews.llvm.org/D63088
Files:
clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
clang-tools-extra/test/clang-tidy/misc-unused-parameters.c
Index: clang-tools-extra/test/clang-tidy/misc-unused-parameters.c
===================================================================
--- clang-tools-extra/test/clang-tidy/misc-unused-parameters.c
+++ clang-tools-extra/test/clang-tidy/misc-unused-parameters.c
@@ -4,7 +4,7 @@
// =============
void a(int i) {;}
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: parameter 'i' is unused [misc-unused-parameters]
-// CHECK-FIXES: {{^}}void a(int /*i*/) {;}{{$}}
+// CHECK-FIXES: {{^}}void a(int i) {;}{{$}}
static void b(); // In C, forward declarations can leave out parameters.
static void b(int i) {;}
Index: clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
===================================================================
--- clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
+++ clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp
@@ -138,16 +138,20 @@
Indexer = llvm::make_unique<IndexerVisitor>(*Result.Context);
}
- // Comment out parameter name for non-local functions.
+ // Cannot remove parameter for non-local functions.
if (Function->isExternallyVisible() ||
!Result.SourceManager->isInMainFile(Function->getLocation()) ||
!Indexer->getOtherRefs(Function).empty() || isOverrideMethod(Function)) {
- SourceRange RemovalRange(Param->getLocation());
- // Note: We always add a space before the '/*' to not accidentally create a
- // '*/*' for pointer types, which doesn't start a comment. clang-format will
- // clean this up afterwards.
- MyDiag << FixItHint::CreateReplacement(
- RemovalRange, (Twine(" /*") + Param->getName() + "*/").str());
+
+ // Comment out parameter name.
+ if (Result.Context->getLangOpts().CPlusPlus) {
+ SourceRange RemovalRange(Param->getLocation());
+ // Note: We always add a space before the '/*' to not accidentally create
+ // a '*/*' for pointer types, which doesn't start a comment. clang-format
+ // will clean this up afterwards.
+ MyDiag << FixItHint::CreateReplacement(
+ RemovalRange, (Twine(" /*") + Param->getName() + "*/").str());
+ }
return;
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63088.203873.patch
Type: text/x-patch
Size: 2134 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190610/1e7c2d7c/attachment.bin>
More information about the cfe-commits
mailing list