[PATCH] D63086: [analyzer][NoStoreFuncVisitor][NFC] Move methods out-of-line, turn some to static functions

[Kristóf Umann via Phabricator via cfe-commits]

Szelethus created this revision.
Szelethus added reviewers: NoQ, dcoughlin, xazax.hun, rnkovacs, Charusso, baloghadamsoftware.
Szelethus added a project: clang.
Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity.

I personally found NoStoreFuncVisitor very hard to read, and since I'm planning to make other changes to it later on, I think this time is as good as any to make it somewhat more readable.

- Make several methods static functions
- Move non-trivial methods out-of-line
- Add a divider
- Turn non-obvious `auto`s into `Optional<RegionVector>`
- clang-format affected lines


Repository:
  rC Clang

https://reviews.llvm.org/D63086

Files:
  clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63086.203865.patch
Type: text/x-patch
Size: 35722 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190610/d62ecfd2/attachment-0001.bin>