[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay requested changes to this revision.
MyDeveloperDay added a comment.
This revision now requires changes to proceed.

You need to add a unit test in clang/unittests



================
Comment at: docs/ClangFormatStyleOptions.rst:195
+**BitFieldDeclsOnSeparateLines** (``bool``)
+  If ``true``, Linesup Bitfield Declarations.
+
----------------
Nit: Aligns Bitfield Declarations

I think Align is a better work than Linesup


================
Comment at: docs/ClangFormatStyleOptions.rst:197
+
+  This will lineup Bitfield declarations on consecutive lines. This
+  will result in formatting like
----------------
align


================
Comment at: docs/ClangFormatStyleOptions.rst:198
+  This will lineup Bitfield declarations on consecutive lines. This
+  will result in formatting like
+
----------------
end with :


================
Comment at: lib/Format/TokenAnnotator.cpp:2920
+  if(Right.Previous->is(tok::comma) && Style.BitFieldDeclsOnSeparateLines && Right.is(tok::identifier)){
+      if(Right.Next->is(tok::colon)){
+        return true;
----------------
elide the {}


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63062/new/

https://reviews.llvm.org/D63062