[PATCH] D61914: [Support][Test] Time profiler: add regression test

Anton Afanasyev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 7 14:01:29 PDT 2019


anton-afanasyev marked an inline comment as done.
anton-afanasyev added a comment.

In D61914#1534508 <https://reviews.llvm.org/D61914#1534508>, @plotfi wrote:

> cfe/trunk/test/Driver/check-time-trace.cpp appears to fail on Darwin. Did you mean to pass the target explicitly ?


This commit is reverted now. How can I pass the target explicitly?



================
Comment at: cfe/trunk/test/Driver/check-time-trace.cpp:1
+// RUN: %clangxx -ftime-trace %s 2>&1 | grep "Time trace json-file dumped to" \
+// RUN:   | awk '{print $NF}' | xargs cat \
----------------
plotfi wrote:
> This test should probably have // REQUIRES: shell
Thanks! I haven't found `REQUIRES: shell` here: `https://llvm.org/docs/CommandGuide/FileCheck.html`. Does this directive mean the target OS must have utils like `awk` and `xargs`?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61914/new/

https://reviews.llvm.org/D61914





More information about the cfe-commits mailing list