r362816 - Revert rL362792 : [Support][Test] Time profiler: add regression test

Simon Pilgrim via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 7 10:37:05 PDT 2019


Author: rksimon
Date: Fri Jun  7 10:37:04 2019
New Revision: 362816

URL: http://llvm.org/viewvc/llvm-project?rev=362816&view=rev
Log:
Revert rL362792 : [Support][Test] Time profiler: add regression test

Summary:
Add output to `llvm::errs()` when `-ftime-trace` option is enabled,
add regression test checking this option works as expected.

Reviewers: thakis, aganea

Subscribers: cfe-commits, llvm-commits

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D61914
........
Breaks buildbots - @anton-afanasyev please can you take a look?

Removed:
    cfe/trunk/test/Driver/check-time-trace.cpp
Modified:
    cfe/trunk/tools/driver/cc1_main.cpp

Removed: cfe/trunk/test/Driver/check-time-trace.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/check-time-trace.cpp?rev=362815&view=auto
==============================================================================
--- cfe/trunk/test/Driver/check-time-trace.cpp (original)
+++ cfe/trunk/test/Driver/check-time-trace.cpp (removed)
@@ -1,23 +0,0 @@
-// RUN: %clangxx -ftime-trace %s 2>&1 | grep "Time trace json-file dumped to" \
-// RUN:   | awk '{print $NF}' | xargs cat \
-// RUN:   | %python -c 'import json, sys; json.dump(json.loads(sys.stdin.read()), sys.stdout, sort_keys=True, indent=2)' \
-// RUN:   | FileCheck %s
-
-// CHECK: "traceEvents": [
-// CHECK: "args":
-// CHECK: "detail":
-// CHECK: "dur":
-// CHECK: "name": "Source"
-// CHECK-NEXT: "ph":
-// CHECK-NEXT: "pid":
-// CHECK-NEXT: "tid":
-// CHECK-NEXT: "ts":
-// CHECK: "name": "clang"
-// CHECK: "name": "process_name"
-
-#include <iostream>
-
-int main() {
-  std::cout << "Foo" << std::endl;
-  return 0;
-}

Modified: cfe/trunk/tools/driver/cc1_main.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/driver/cc1_main.cpp?rev=362816&r1=362815&r2=362816&view=diff
==============================================================================
--- cfe/trunk/tools/driver/cc1_main.cpp (original)
+++ cfe/trunk/tools/driver/cc1_main.cpp Fri Jun  7 10:37:04 2019
@@ -241,11 +241,6 @@ int cc1_main(ArrayRef<const char *> Argv
 
     llvm::timeTraceProfilerWrite(*profilerOutput);
     llvm::timeTraceProfilerCleanup();
-
-    llvm::errs() << "Time trace json-file dumped to " << Path.str() << "\n";
-    llvm::errs()
-        << "Use chrome://tracing or Speedscope App "
-           "(https://www.speedscope.app) for flamegraph visualization\n";
   }
 
   // Our error handler depends on the Diagnostics object, which we're




More information about the cfe-commits mailing list