[PATCH] D60710: [ARM] Add ACLE feature macros for MVE.

Oliver Stannard (Linaro) via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 7 05:24:37 PDT 2019


ostannard added inline comments.


================
Comment at: clang/lib/Basic/Targets/ARM.cpp:465
+      MVE |= MVE_INT | MVE_FP;
+      HW_FP |= HW_FP_SP | HW_FP_HP;
     }
----------------
SjoerdMeijer wrote:
> ostannard wrote:
> > Does this also need to set FPU and HasLegalHalfType?
> Yep, thanks for catching this one, will fix this.
What about FPU? mve.fp requires that the FPU is also enabled, so we should also get the ##__ARM_FPV5__## macro (unless we're adding a new one for the v8.1M FPU?).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60710/new/

https://reviews.llvm.org/D60710





More information about the cfe-commits mailing list