[PATCH] D62998: [ARM] Fix bugs introduced by the fp64/d32 rework.

Oliver Stannard (Linaro) via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 7 01:57:21 PDT 2019


ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.

LGTM with one change.



================
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:294
 
+  std::vector<StringRef> FeaturesAfter;
+
----------------
You explained it in the commit message, but I think this could do with a comment in the code too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62998/new/

https://reviews.llvm.org/D62998





More information about the cfe-commits mailing list