[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

Aaron Puchert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 5 09:24:36 PDT 2019


aaronpuchert added a comment.

In D59673#1527487 <https://reviews.llvm.org/D59673#1527487>, @aaronpuchert wrote:

> In D59673#1521413 <https://reviews.llvm.org/D59673#1521413>, @dblaikie wrote:
>
> > Might be easier as a few patches - renaming the existing option, adding the new one, then removing the single split dwarf flag handling in favor of implying that by the absence of an output file name.
>
>
> No problem, makes sense to me. I'll see if it's possible to separate these changes.


I have managed to split this into commits that build and test fine own their own, but there are temporary inconsistencies. If I rename `-split-dwarf-file` to `-split-dwarf-output` first, then I have to use that option for `-enable-split-dwarf=single`, and then I reintroduce `-split-dwarf-file` and have to change it back. It's not a huge problem, but it might feel a bit weird. On the other hand, the changes are indeed smaller and easier to review. I will push them later today (hopefully).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59673/new/

https://reviews.llvm.org/D59673





More information about the cfe-commits mailing list