[PATCH] D62441: [analyzer] NFC: Introduce a convenient CallDescriptionMap class.

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 5 01:59:04 PDT 2019


xazax.hun requested changes to this revision.
xazax.hun added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1088
+  // descriptions (eg., the ones for C functions that just match the name).
+  const std::vector<std::pair<CallDescription, T>> LinearMap;
+
----------------
Will the move constructor work as intended with const members?


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:1097
+  // we don't do redundant copies.
+  CallDescriptionMap(const CallDescriptionMap &) = delete;
+
----------------
I think in this case copy assignment should also be deleted. Or is it deleted automatically in this case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62441/new/

https://reviews.llvm.org/D62441





More information about the cfe-commits mailing list