[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

Zixuan Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 4 20:38:53 PDT 2019


wuzish added inline comments.

/cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 @hubert.reinterpretcast 
Thanks for your advice. I think the name `ppc_wrappers` is accurate to describe its meaning that wrapping the headers under standard library path or standard header search path. (Headers in lib/Headers is clang standard search path) It's truly that `ppc_wrappers` can be used for all platforms of powerpc no matter what's OS or bit mode or endian because there are only little num of files and no need for too many level directory. And we can distinguish OS, endian or mode by macros in wrapped headers, combining with `#include_next` as what you said, which I also prefer to use because it's easier to maintain headers instead of modifying cpp code about toolchain class such as `PPCLinuxToolChain `.

We will use better way described above to guard those headers only in 64-bit mode soon after other headers have been upstreamed.

https://reviews.llvm.org/rL358949





More information about the cfe-commits mailing list