[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 4 17:16:51 PDT 2019


Szelethus marked an inline comment as done.
Szelethus added a comment.

For the test files where plist files have changed: (note to self: there has **got to be** a better way to show this off)

F9062068: track_cond_undef_value_param_before.html <https://reviews.llvm.org/F9062068>
F9062011: track_cond_undef_value_param_after.html <https://reviews.llvm.org/F9062011>

F9062176: track_cond_unix_fns_before.html <https://reviews.llvm.org/F9062176>
F9062279: track_cond_unix_fns_after.html <https://reviews.llvm.org/F9062279>

F9062777: track_cond_retain_release_m_objc_1_before.html <https://reviews.llvm.org/F9062777>
F9062772: track_cond_retain_release_m_objc_1_after.html <https://reviews.llvm.org/F9062772>

(same for the .*objcpp file)
F9062784: track_cond_retain_release_m_objc_2_before.html <https://reviews.llvm.org/F9062784>
F9062797: track_cond_retain_release_m_objc_2_after.html <https://reviews.llvm.org/F9062797>

F9062927: track_cond_edges_new_before.html <https://reviews.llvm.org/F9062927>
F9062929: track_cond_edges_new_after.html <https://reviews.llvm.org/F9062929>

F9063089: track_cond_cxx_for_range_before.html <https://reviews.llvm.org/F9063089>
F9063092: track_cond_cxx_for_range_after.html <https://reviews.llvm.org/F9063092>



================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1863-1864
+
+    case Stmt::ObjCForCollectionStmtClass:
+      return cast<ObjCForCollectionStmt>(S)->getCollection();
+
----------------
@NoQ Any feelings on this?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62883/new/

https://reviews.llvm.org/D62883





More information about the cfe-commits mailing list