[PATCH] D59744: Fix i386 ABI "__m64" type bug

Kamil Rytarowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 4 16:46:04 PDT 2019


krytarowski added a comment.

In D59744#1529218 <https://reviews.llvm.org/D59744#1529218>, @mgorny wrote:

> In D59744#1529182 <https://reviews.llvm.org/D59744#1529182>, @krytarowski wrote:
>
> > In D59744#1527412 <https://reviews.llvm.org/D59744#1527412>, @wxiao3 wrote:
> >
> > > Consider other Systems (e.g Darwin, PS4 and FreeBSD) don't want to spend any effort dealing with the ramifications of ABI breaks (as discussed in https://reviews.llvm.org/D60748) at present, I only fix the bug for Linux. If other system wants the fix, the only thing needed is to add a flag (like "IsLinuxABI" ) to enable it.
> >
> >
> > CC @mgorny and @joerg - do we want this for NetBSD?
>
>
> Probably yes. FWICS, gcc uses `%mm0` and `%mm1` on NetBSD while clang doesn't.


Unless Joerg will protest, @wxiao3 please enable it on NetBSD as well.. but personally I would enable it unconditionally for all sysv ABIs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59744/new/

https://reviews.llvm.org/D59744





More information about the cfe-commits mailing list