[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC
Russell Gallop via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 4 09:55:00 PDT 2019
russell.gallop added a comment.
> Then the test should be failing? Or is the current form also legal?
Hmm, __builtin_ia32_insertps128() errors if you pass a variable, but these don't (e.g.):
mytest.c:122:13: error: argument to '__builtin_ia32_insertps128' must be a constant integer
tmp_V4f = __builtin_ia32_insertps128(tmp_V4f, tmp_V4f, tmp_i);
I'll have a look and see if there is a reason why these don't fail in the same way (which would make the test fail in it's current form).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62850/new/
https://reviews.llvm.org/D62850
More information about the cfe-commits
mailing list