[PATCH] D62850: [X86] Fix builtins-x86.c test where it wasn't using immediates. NFC
Russell Gallop via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 4 05:28:13 PDT 2019
russell.gallop added a comment.
> .. or?
I'm not sure what you mean.
> Is this fixing a current test failure?
No. The test is not failing, but it is not doing what was intended as these builtins are for generating the immediate form of the corresponding instruction and they were generating actually generating a register form.
This test doesn't check the instructions generated are correct, but fixing that is a bigger task...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62850/new/
https://reviews.llvm.org/D62850
More information about the cfe-commits
mailing list