[clang-tools-extra] r362469 - [clangd] Fix a crash when clang-tidy is disabled

[Ilya Biryukov via cfe-commits]

Author: ibiryukov
Date: Tue Jun  4 00:19:11 2019
New Revision: 362469

URL: http://llvm.org/viewvc/llvm-project?rev=362469&view=rev
Log:
[clangd] Fix a crash when clang-tidy is disabled

Added:
    clang-tools-extra/trunk/clangd/test/diagnostics-no-tidy.test
Modified:
    clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp

Added: clang-tools-extra/trunk/clangd/test/diagnostics-no-tidy.test
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/test/diagnostics-no-tidy.test?rev=362469&view=auto
==============================================================================
--- clang-tools-extra/trunk/clangd/test/diagnostics-no-tidy.test (added)
+++ clang-tools-extra/trunk/clangd/test/diagnostics-no-tidy.test Tue Jun  4 00:19:11 2019
@@ -0,0 +1,39 @@
+# RUN: clangd -lit-test -clang-tidy=false < %s | FileCheck -strict-whitespace %s
+{"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPath":"clangd","capabilities":{},"trace":"off"}}
+---
+{"jsonrpc":"2.0","method":"textDocument/didOpen","params":{"textDocument":{"uri":"test:///foo.c","languageId":"c","version":1,"text":"void main() {\n(void)sizeof(42);\n}"}}}
+#      CHECK:  "method": "textDocument/publishDiagnostics",
+# CHECK-NEXT:  "params": {
+# CHECK-NEXT:    "diagnostics": [
+# CHECK-NEXT:      {
+# CHECK-NEXT:        "code": "-Wmain-return-type",
+# CHECK-NEXT:        "message": "Return type of 'main' is not 'int' (fix available)",
+# CHECK-NEXT:        "range": {
+# CHECK-NEXT:          "end": {
+# CHECK-NEXT:            "character": 4,
+# CHECK-NEXT:            "line": 0
+# CHECK-NEXT:          },
+# CHECK-NEXT:          "start": {
+# CHECK-NEXT:            "character": 0,
+# CHECK-NEXT:            "line": 0
+# CHECK-NEXT:          }
+# CHECK-NEXT:        },
+# CHECK-NEXT:        "severity": 2,
+# CHECK-NEXT:        "source": "clang"
+# CHECK-NEXT:      }
+# CHECK-NEXT:    ],
+# CHECK-NEXT:    "uri": "file://{{.*}}/foo.c"
+# CHECK-NEXT:  }
+---
+{"jsonrpc":"2.0","id":2,"method":"sync","params":null}
+---
+{"jsonrpc":"2.0","method":"textDocument/didClose","params":{"textDocument":{"uri":"test:///foo.c"}}}
+#      CHECK:  "method": "textDocument/publishDiagnostics",
+# CHECK-NEXT:  "params": {
+# CHECK-NEXT:    "diagnostics": [],
+# CHECK-NEXT:    "uri": "file://{{.*}}/foo.c"
+# CHECK-NEXT:  }
+---
+{"jsonrpc":"2.0","id":5,"method":"shutdown"}
+---
+{"jsonrpc":"2.0","method":"exit"}

Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp?rev=362469&r1=362468&r2=362469&view=diff
==============================================================================
--- clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp (original)
+++ clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp Tue Jun  4 00:19:11 2019
@@ -512,14 +512,14 @@ int main(int argc, char *argv[]) {
         tidy::ClangTidyGlobalOptions(),
         /* Default */ tidy::ClangTidyOptions::getDefaults(),
         /* Override */ OverrideClangTidyOptions, FSProvider.getFileSystem());
+    Opts.GetClangTidyOptions = [&](llvm::vfs::FileSystem &,
+                                   llvm::StringRef File) {
+      // This function must be thread-safe and tidy option providers are not.
+      std::lock_guard<std::mutex> Lock(ClangTidyOptMu);
+      // FIXME: use the FS provided to the function.
+      return ClangTidyOptProvider->getOptions(File);
+    };
   }
-  Opts.GetClangTidyOptions = [&](llvm::vfs::FileSystem &,
-                                 llvm::StringRef File) {
-    // This function must be thread-safe and tidy option providers are not.
-    std::lock_guard<std::mutex> Lock(ClangTidyOptMu);
-    // FIXME: use the FS provided to the function.
-    return ClangTidyOptProvider->getOptions(File);
-  };
   Opts.SuggestMissingIncludes = SuggestMissingIncludes;
   llvm::Optional<OffsetEncoding> OffsetEncodingFromFlag;
   if (ForceOffsetEncoding != OffsetEncoding::UnsupportedEncoding)