[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool
Chris Bieneman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 3 17:24:16 PDT 2019
beanz added a comment.
I have a thought for how we can make the CMake interface for this better. Instead of `LLVM_EXTENSIONS` being a global property if it were a pre-defined list like `LLVM_ALL_PROJECTS`, then the `LLVM_LINK_<X>_INTO_TOOLS` variables can be generated by LLVM's configuration instead of relying on Polly's to run. If you do that `LLVM_LINK_POLLY_INTO_TOOLS` could be set to `On` even if Polly isn't enabled to build, but that actually will be fine if you change the calls to `target_link_libraries` in the tools to use a generator expression something like: `$<$<TARGET_EXISTS:Polly>,Polly>`.
These changes should eliminate the order-dependence on the tools and allow the first configuration run to be accurate.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61446/new/
https://reviews.llvm.org/D61446
More information about the cfe-commits
mailing list