[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia added a comment.

In D62584#1522438 <https://reviews.llvm.org/D62584#1522438>, @rjmccall wrote:

> I think the right approach here is probably to make sure you're applying deduction during instantiation as well.


I agree I think we might need to extend the template instantiation logic to account for some corner cases. However, all local variables in OpenCL are to be deduced to `__private`, therefore would it be better to deduce them already as we parse the template definition instead of doing it multiple times on each instantiation? It doesn't seem the template argument should affect this rule...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62584/new/

https://reviews.llvm.org/D62584