[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 3 07:30:52 PDT 2019


steakhal updated this revision to Diff 202717.
steakhal added a comment.

Unfortunately the changes that I've made are not available in a diff because I've moved to the monorepo version.
Although, you can see the changes in detail on my llvm-project github fork <https://github.com/llvm/llvm-project/compare/master...steakhal:incorrect-pointer-cast>.

There were only minor changes.

- Updated the license, as requested
- Moved the checker to the 'bugprone' category from 'misc'
- Fixed bug: now using `getAsRecordDecl` instead of `getAsCXXRecordDecl`

**There is still an open question** whether we should relay on the warnings of the `-Wcast-align` option, but I'm not convinced.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D48866/new/

https://reviews.llvm.org/D48866

Files:
  clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp
  clang-tools-extra/clang-tidy/bugprone/CMakeLists.txt
  clang-tools-extra/clang-tidy/bugprone/IncorrectPointerCastCheck.cpp
  clang-tools-extra/clang-tidy/bugprone/IncorrectPointerCastCheck.h
  clang-tools-extra/docs/ReleaseNotes.rst
  clang-tools-extra/docs/clang-tidy/checks/bugprone-incorrect-pointer-cast.rst
  clang-tools-extra/docs/clang-tidy/checks/list.rst
  clang-tools-extra/test/clang-tidy/bugprone-incorrect-pointer-cast.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48866.202717.patch
Type: text/x-patch
Size: 21347 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190603/9e938aa7/attachment-0001.bin>


More information about the cfe-commits mailing list