[PATCH] D62616: [CodeComplete] Add a bit more whitespace to completed patterns

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 3 01:05:51 PDT 2019


ilya-biryukov added a comment.

In D62616#1522284 <https://reviews.llvm.org/D62616#1522284>, @gribozavr wrote:

> I totally agree about the space before the opening curly, but the space before the opening paren is a matter of style.  Certainly it does match LLVM style better, but it does not match some other styles.
>
> I guess there's no way to satisfy everyone without an automatic reformatter, and if we were to pick a "default" style it might as well be LLVM, so I approve.


Totally agree. I was also torn on this, but since there's no reasonable way to get the formatting options on code completion now, matching the LLVM style looks like the best trade-off.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62616/new/

https://reviews.llvm.org/D62616





More information about the cfe-commits mailing list