[PATCH] D59744: Fix i386 ABI "__m64" type bug

Wei Xiao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Jun 1 20:07:50 PDT 2019


wxiao3 added a comment.

Hi all,

With the latest version, I have made below changes according to all your comments:

1. Only apply the fix to Linux where many libraries are built by GCC.
2. Avoid converting the QualType to llvm::Type and then checking if the llvm::Type is a 64-bit vector, which is unnecessary and inefficient. Furthermore, I remove the utility function: IsX86_MMXType since It's very simple to check _m64 type based on QualType.

Ok for merge now?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59744/new/

https://reviews.llvm.org/D59744





More information about the cfe-commits mailing list