[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

Thu May 30 12:55:35 PDT 2019

nickdesaulniers added a comment.

Was this committed accidentally?

Today in master I see:

- r362106: Revert "clang support gnu asm goto." Erich Keane <erich.keane at intel.com>
- r362059: Mark CodeGen/asm-goto.c as x86 specific after r362045 Fangrui Song <maskray at google.com>
- r362045: clang support gnu asm goto. Jennifer Yu <jennifer.yu at intel.com>

and yet this Phabricator review is still open.

It may be easier to rebase this into a monorepo checkout, then commit with `git llvm push`.
https://llvm.org/docs/GettingStarted.html#for-developers-to-commit-changes-from-git

As @kees  noted, for new test files that contain x86 assembly, they need a `-triple` that specifies an x86 target, otherwise the implicit target is based on the host, which may not be x86.  We still want to verify that non-x86 host can cross compile to x86 correctly.  Sorry we did not catch this earlier in code review.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56571/new/

https://reviews.llvm.org/D56571