r356569 - [NFC][clang][astdump] Some baseline tests for OpenMP

[Roman Lebedev via cfe-commits]

On Sat, Jun 1, 2019 at 2:00 AM Richard Smith <richard at metafoo.co.uk> wrote:
>
> These are change detector tests (https://testing.googleblog.com/2015/01/testing-on-toilet-change-detector-tests.html) and create a significant maintenance burden that exceeds their value.
>
> Please either reduce these to tests that actually test specific salient properties (rather than just being assertions that the AST does not change) or remove them.
Yep, lack of tooling indeed always makes things rather frustrating.
I have recently highlighted that in yet another AST thread:
https://lists.llvm.org/pipermail/cfe-dev/2019-April/061997.html

I personally added those tests to highlight the openmp_structured_block
changes, but there is also unit-test coverage for that.

If maintaining test coverage turns out to be too problematic,
feel free to degrade the test coverage as you see fit,
but i stand by my opinion that it is a preexisting tooling issue.
(same with clang codegen tests, diags, etc etc)

Roman.

> On Wed, 20 Mar 2019 at 11:16, Roman Lebedev via cfe-commits <cfe-commits at lists.llvm.org> wrote:
>>
>> Author: lebedevri
>> Date: Wed Mar 20 09:31:47 2019
>> New Revision: 356569
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=356569&view=rev
>> Log:
>> [NFC][clang][astdump] Some baseline tests for OpenMP
>>
>> Summary:
>> Split off from D59214.
>> Not a fully exhaustive test coverage, but better than what there currently is.
>>
>> Differential Revision: https://reviews.llvm.org/D59306
>>
>> Added:
>>     cfe/trunk/test/AST/ast-dump-openmp-atomic.c
>>     cfe/trunk/test/AST/ast-dump-openmp-barrier.c
>>     cfe/trunk/test/AST/ast-dump-openmp-cancel.c
>>     cfe/trunk/test/AST/ast-dump-openmp-cancellation-point.c
>>     cfe/trunk/test/AST/ast-dump-openmp-critical.c
>>     cfe/trunk/test/AST/ast-dump-openmp-distribute-parallel-for-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-distribute-parallel-for.c
>>     cfe/trunk/test/AST/ast-dump-openmp-distribute-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-distribute.c
>>     cfe/trunk/test/AST/ast-dump-openmp-flush.c
>>     cfe/trunk/test/AST/ast-dump-openmp-for-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-for.c
>>     cfe/trunk/test/AST/ast-dump-openmp-master.c
>>     cfe/trunk/test/AST/ast-dump-openmp-ordered.c
>>     cfe/trunk/test/AST/ast-dump-openmp-parallel-for-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-parallel-for.c
>>     cfe/trunk/test/AST/ast-dump-openmp-parallel-master-XFAIL.c
>>     cfe/trunk/test/AST/ast-dump-openmp-parallel-sections.c
>>     cfe/trunk/test/AST/ast-dump-openmp-parallel.c
>>     cfe/trunk/test/AST/ast-dump-openmp-section.c
>>     cfe/trunk/test/AST/ast-dump-openmp-sections.c
>>     cfe/trunk/test/AST/ast-dump-openmp-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-single.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-data.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-enter-data.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-exit-data.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-parallel-for-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-parallel-for.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-parallel.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-teams-distribute-parallel-for-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-teams-distribute-parallel-for.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-teams-distribute-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-teams-distribute.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-teams.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target-update.c
>>     cfe/trunk/test/AST/ast-dump-openmp-target.c
>>     cfe/trunk/test/AST/ast-dump-openmp-task.c
>>     cfe/trunk/test/AST/ast-dump-openmp-taskgroup.c
>>     cfe/trunk/test/AST/ast-dump-openmp-taskloop-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-taskloop.c
>>     cfe/trunk/test/AST/ast-dump-openmp-taskwait.c
>>     cfe/trunk/test/AST/ast-dump-openmp-taskyield.c
>>     cfe/trunk/test/AST/ast-dump-openmp-teams-distribute-parallel-for-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-teams-distribute-parallel-for.c
>>     cfe/trunk/test/AST/ast-dump-openmp-teams-distribute-simd.c
>>     cfe/trunk/test/AST/ast-dump-openmp-teams-distribute.c
>>     cfe/trunk/test/AST/ast-dump-openmp-teams.c
>>
>...