[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306
+        if (CEArg->isElidable()) {
+          if (const auto *TempExp = CEArg->getArg(0)) {
+            if (const auto *UnwrappedCE =
----------------
Eugene.Zelenko wrote:
> gribozavr wrote:
> > Eugene.Zelenko wrote:
> > > Return type is not mentioned explicitly, so auto should not be used.
> > An explicit type is not needed for readability here.  The rule is to use auto when it improves readability, not when the type is not spelled in immediate vicinity.
> I think it's reasonable to follow modernize-use-auto.
modernize-use-auto is only a heuristic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62736/new/

https://reviews.llvm.org/D62736