[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options
Roman Lebedev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 31 07:26:49 PDT 2019
lebedev.ri added a comment.
New files are missing header blurbs; the **precise** explanation of what is what is missing (should be in `doc/`, not patch description)
================
Comment at: include/llvm/IR/FPState.h:9-31
+ enum FPModelKind {
+ FPM_Off,
+ FPM_Precise,
+ FPM_Strict,
+ FPM_Fast
+ };
+
----------------
All this needs comments, and possibly better names.
`FPM_Off`,etc is very non-self-explanatory.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62730/new/
https://reviews.llvm.org/D62730
More information about the cfe-commits
mailing list