[PATCH] D62367: [X86] VP2INTERSECT clang

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.


================
Comment at: lib/Headers/avx512vlvp2intersectintrin.h:39
+
+/// This instruction writes an even/odd pair of mask registers. The mask
+/// register destination indicated in the MODRM.REG field is used to form
----------------
This doesn't really say anything about what's in the mask registers. I don' think any of the MODRM encoding details are relevant here. I think a better description would be what's in the table in the ISE manual.  "Store, in an even/odd pair of mask registers,
the indicators of the locations of value
matches between dwords in
xmm3/m128/m32bcst and xmm2."


================
Comment at: lib/Headers/avx512vlvp2intersectintrin.h:46
+///
+/// This intrinsic corresponds to the <c> AVX512-VP2INTERSECT </c> instruction.
+///
----------------
Drop the "AVX512-". Add the proper D/Q suffix. This should be the instruction mnemonic


================
Comment at: lib/Headers/avx512vlvp2intersectintrin.h:53
+/// \param __m0
+///    A point ponit to 8-bit mask 
+/// \param __m1
----------------
ponit?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62367/new/

https://reviews.llvm.org/D62367