[PATCH] D61939: AArch64: add support for arm64_23 (ILP32) IR generation

Florian Hahn via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 30 15:59:56 PDT 2019


fhahn added a comment.

Hi Tim. Would it be possible to split this in the 'trivial' changes (extending the triple handling for example) and the arm64_32 related changes to size, ABI stuff and so on? The trivial changes look good to me and by splitting them  off people can focus on reviewing the more important changes.



================
Comment at: clang/lib/Basic/Targets/AArch64.h:93
+
+  bool hasInt128Type() const override;
 };
----------------
Why is this needed? It seems unused in the diff?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61939/new/

https://reviews.llvm.org/D61939





More information about the cfe-commits mailing list