[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Thu May 30 13:59:09 PDT 2019

NoQ marked an inline comment as done.
NoQ added inline comments.

================
Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:326
+            self._dump('<b>Program point:</b></td></tr>')
+        self._dump('<tr><td align="left" balign="left" width="0">'
+                   '<table border="0" align="left" width="0">')
----------------
Charusso wrote:
> I would create a table-builder class to reduce the repetition and for better readability what is going on. Also you could avoid `balign` typo.
> 
> Then may each class could have its own pretty-print method like LLVM does.
`balign` is a thing in the graphviz dialect of html (https://www.graphviz.org/doc/info/shapes.html)

(not sure i still need this in the current incarnation of the script, given that we've removed those whole-decl pretty-prints in D62495)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62638/new/

https://reviews.llvm.org/D62638