[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

Shafik Yaghmour via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 29 16:26:42 PDT 2019


shafik added a comment.

So an alternative to testing could be matching the AST output from a `clang-import-test` like we did here:

https://reviews.llvm.org/D61140

although it unfortunately looks like only only the AST dump of `NamespaceDecl` output the `SourceLocation` you are fixing, see it on godbolt <https://godbolt.org/z/pVrrXe> when I try a `clang-import-test` it looks like it is missing that `SourceLocation`:

  |-NamespaceDecl 0x7f8c1f884750 <enum.cpp:1:1, <invalid sloc>> col:11 

and with your patch applied I see the `SourceLocation`:

  |-NamespaceDecl 0x7fe3e6882f50 <enum.cpp:1:1, line:7:1> line:1:11 A


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60499/new/

https://reviews.llvm.org/D60499





More information about the cfe-commits mailing list