[PATCH] D62611: [analyzer][Dominators] Add unittests

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 29 11:36:12 PDT 2019


Szelethus marked 5 inline comments as done.
Szelethus added inline comments.


================
Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:95
+  CFGPostDomTree PostDom;
+  PostDom.buildDominatorTree(cfg);
+
----------------
kuhar wrote:
> Why not have a constructor that takes the cfg and constructs a domtree straight away? But this should probably go into a separate patch.
Yea, it's been bothering me for a while, but apparently not enough to fix it (just yet!).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62611/new/

https://reviews.llvm.org/D62611





More information about the cfe-commits mailing list