[PATCH] D61912: [analyzer] print() JSONify: Store implementation

Wed May 29 10:14:41 PDT 2019

Szelethus added a comment.

In D61912#1521411 <https://reviews.llvm.org/D61912#1521411>, @Charusso wrote:

> >> In D61912#1521306 <https://reviews.llvm.org/D61912#1521306>, @lebedev.ri wrote:
> >> 
> >>> All these patches bypassed cfe-commits.
> >> 
> >> 
> >> Bypassed? It is only added when you push your stuff, which is happened as expected.
> > 
> > That is pretty much the opposite from what is exected, e.g.:
> >  https://llvm.org/docs/Phabricator.html
> > 
> >> While Phabricator is a useful tool for some, the relevant -commits mailing list
> >>  is the system of record for all LLVM code review. The mailing list should be added
> >>  as a subscriber on all reviews, and Phabricator users should be prepared to respond
> >>  to free-form comments in mail sent to the commits list.
>
> Hm, in my mind it was in the proper order, as you could see that. Thanks for the clarification! I will add it.

I think cfe-commits is added automatically if you add "Clang" to the "Repository" field when creating a new Differential.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61912/new/

https://reviews.llvm.org/D61912