[PATCH] D61912: [analyzer] print() JSONify: Store implementation
Csaba Dabis via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed May 29 09:10:01 PDT 2019
Charusso added a comment.
Hey @lebedev.ri, thanks for the review!
In D61912#1521306 <https://reviews.llvm.org/D61912#1521306>, @lebedev.ri wrote:
> All these patches bypassed cfe-commits.
Bypassed? It is only added when you push your stuff, which is happened as expected.
> Why does this invent a yet another json formatter instead of using
> `"llvm/Support/JSON.h"`, in particular it's lightweight `json::OStream` ?
We are doing our own JSON representation which is not really the job of `json` namespace. Also it is my personal feeling to avoid writing::like::that for perfectly no reason.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61912/new/
https://reviews.llvm.org/D61912
More information about the cfe-commits
mailing list