[clang-tools-extra] r361952 - [clangd] Remove the whitelist std symbols in CanonicalIncludes.
Haojian Wu via cfe-commits
cfe-commits at lists.llvm.org
Wed May 29 05:08:11 PDT 2019
Author: hokein
Date: Wed May 29 05:08:11 2019
New Revision: 361952
URL: http://llvm.org/viewvc/llvm-project?rev=361952&view=rev
Log:
[clangd] Remove the whitelist std symbols in CanonicalIncludes.
Summary: These symbols have been included via StdSymbolMap.inc.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D62527
Modified:
clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp
URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp?rev=361952&r1=361951&r2=361952&view=diff
==============================================================================
--- clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp (original)
+++ clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp Wed May 29 05:08:11 2019
@@ -87,31 +87,14 @@ collectIWYUHeaderMaps(CanonicalIncludes
}
void addSystemHeadersMapping(CanonicalIncludes *Includes) {
- static const std::vector<std::pair<const char *, const char *>> SymbolMap = {
- // Map symbols in <iosfwd> to their preferred includes.
- {"std::basic_filebuf", "<fstream>"},
- {"std::filebuf", "<fstream>"},
- {"std::wfilebuf", "<fstream>"},
- {"std::basic_istream", "<istream>"},
- {"std::istream", "<istream>"},
- {"std::wistream", "<istream>"},
- {"std::basic_ostream", "<ostream>"},
- {"std::ostream", "<ostream>"},
- {"std::wostream", "<ostream>"},
- {"std::uint_least16_t", "<cstdint>"}, // <type_traits> redeclares these
- {"std::uint_least32_t", "<cstdint>"},
#define SYMBOL(Name, NameSpace, Header) { #NameSpace#Name, #Header },
#include "StdSymbolMap.inc"
#undef SYMBOL
};
- for (const auto &Pair : SymbolMap)
- Includes->addSymbolMapping(Pair.first, Pair.second);
// FIXME: remove the std header mapping once we support ambiguous symbols, now
// it serves as a fallback to disambiguate:
// - symbols with mulitiple headers (e.g. std::move)
- // - symbols with a primary template in one header and a specialization in
- // another (std::abs)
static const std::vector<std::pair<const char *, const char *>>
SystemHeaderMap = {
{"include/__stddef_max_align_t.h", "<cstddef>"},
More information about the cfe-commits
mailing list