[PATCH] D62573: [Index] Correctly set symbol kind of IndirectFieldDecl

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 29 03:07:46 PDT 2019


ilya-biryukov added a comment.

In D62573#1520641 <https://reviews.llvm.org/D62573#1520641>, @kadircet wrote:

> Do you think it would be beneficial to add some logging for the default case of that switch statement ?


We should replace `default` with all cases it covers to make sure we get a warning when adding a new kind.
But I'm not sure it's going to be a big improvement, maybe it would be even nicer to replace this with some macro magic involving `#include "DeclKinds.inc"`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62573/new/

https://reviews.llvm.org/D62573





More information about the cfe-commits mailing list