[PATCH] D61601: [clangd] Represent Hover result using FormattedString

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 29 02:55:25 PDT 2019


ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1170
     else if (NamespaceScope->empty())
-      Out << "global namespace";
+      Output.appendText(" global namespace");
     else
----------------
kadircet wrote:
> Should this also be `inlinecode`, for consistency? I know it is not exactly code as the other two cases, but it might still be better to look similar in all cases
Yeah, wasn't sure. Turned into inline code, could tweak later if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61601/new/

https://reviews.llvm.org/D61601





More information about the cfe-commits mailing list