[PATCH] D61601: [clangd] Represent Hover result using FormattedString

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 29 02:43:46 PDT 2019


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: clang-tools-extra/clangd/XRefs.cpp:1170
     else if (NamespaceScope->empty())
-      Out << "global namespace";
+      Output.appendText(" global namespace");
     else
----------------
Should this also be `inlinecode`, for consistency? I know it is not exactly code as the other two cases, but it might still be better to look similar in all cases


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61601/new/

https://reviews.llvm.org/D61601





More information about the cfe-commits mailing list