[PATCH] D62005: [libunwind] [test] Fix inferring source paths

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 29 00:16:24 PDT 2019


mgorny marked 2 inline comments as done.
mgorny added inline comments.


================
Comment at: libunwind/test/libunwind/test/config.py:27
+        self.libcxx_src_root = (self.get_lit_conf('libcxx_src_root')
+            or os.path.join(self.libunwind_src_root, '../libcxx'))
 
----------------
phosek wrote:
> Can you use `os.path.join(self.libunwind_src_root, '..', 'libcxx')` to make it compatible with systems that don't use `/` as path separators?
Good catch. Will do.


Repository:
  rUNW libunwind

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62005/new/

https://reviews.llvm.org/D62005





More information about the cfe-commits mailing list