[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

Tue May 28 19:32:13 PDT 2019

stephanemoore reopened this revision.
stephanemoore added inline comments.
This revision is now accepted and ready to land.

================
Comment at: test/clang-tidy/google-objc-global-variable-declaration.m:48
 static NSString* gMyIntGood = 0;
+extern NSString* Y2Good;

----------------
Whoops, we forgot the warning that should be generated for this case 😅

Test failure(s):
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/49124
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/49124/steps/test/logs/stdio

I had to rollback the commit. Can you update the patch to resolve the test failure(s)?

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62045/new/

https://reviews.llvm.org/D62045