[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

Tue May 28 18:14:16 PDT 2019

aheejin added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214
+  if (getTriple().isOSEmscripten()) {
+    Res |= SanitizerKind::Vptr;
+  }
----------------
aheejin wrote:
> quantum wrote:
> > aheejin wrote:
> > > quantum wrote:
> > > > aheejin wrote:
> > > > > Does this mean we only support `Vptr` among sanitizers [[ https://github.com/llvm/llvm-project/blob/92d706eaca6cc79501066eae4392b600008e52c1/clang/include/clang/Basic/Sanitizers.def#L76-L103 | here ]]?
> > > > No, by default all of UBSan except `Vptr` and `Function` are declared as supported. This adds Vptr to the list as it's supported on Emscripten.
> > > I see. By the way where do we say we support the undefined sanitizer group?
> > The base `ToolChain` class says it's supported on all platforms.
> By the way [[ https://github.com/llvm/llvm-project/blob/92d706eaca6cc79501066eae4392b600008e52c1/clang/include/clang/Basic/Sanitizers.def#L129-L137 | this ]] seems to include `Vptr` as well..? Am I looking at the wrong place?
Oh nevermind, the base method explicitly excludes `Vptr` and `Function`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62559/new/

https://reviews.llvm.org/D62559