[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 28 10:58:45 PDT 2019


rnk added a comment.

In D61742#1519539 <https://reviews.llvm.org/D61742#1519539>, @russell.gallop wrote:

> > I was going to suggest that maybe what we should do is just embed the basename, i.e. /nodefaultlib:clang_rt.profile-x86_64.lib ...
>
> Do you mean /defaultlib:clang_rt.profile-x86_64.lib?
>
> > ... and then we just ask users to add one /libpath: flag to their linker invocation
>
> I'll try that. If it works, should we revisit the ubsan dependent lib support, to be consistent?


Yes, definitely. I'd like to do the same for asan, but things there are complicated by the various CRT linking modes.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61742/new/

https://reviews.llvm.org/D61742





More information about the cfe-commits mailing list