[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 28 09:37:24 PDT 2019


rnk added a comment.

I was going to suggest that maybe what we should do is just embed the basename, i.e. `/nodefaultlib:clang_rt.profile-x86_64.lib`, and then we just ask users to add one `/libpath:` flag to their linker invocation. That saves users from having to come up with a mapping from their build system CPU name to whatever compiler-rt is using (i686, i386, x86-64, x86_64h, etc). Users should probably put clang's library directory on libpath anyway if they want to be able to find the builtins library, which might be necessary even in a standard (no-pgo, no-coverage) build configuration. This is also consistent with MSVC in some ways, which autolinks the CRT this way.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61742/new/

https://reviews.llvm.org/D61742





More information about the cfe-commits mailing list